[Asterisk-code-review] res_pjsip: Replace invalid UTF-8 sequences in callerid name (asterisk[18])

[Joshua Colp]

Attention is currently required from: Sean Bright, George Joseph.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19898 )

Change subject: res_pjsip: Replace invalid UTF-8 sequences in callerid name
......................................................................


Patch Set 7: Code-Review-1

(3 comments)

File include/asterisk/utf8.h:

https://gerrit.asterisk.org/c/asterisk/+/19898/comment/f9fbba20_c91491c9 
PS7, Line 136:  * 3 byte sequence, the destination buffer will beed to be larger than
need


File main/stasis_channels.c:

https://gerrit.asterisk.org/c/asterisk/+/19898/comment/9c520006_8790f7f5 
PS7, Line 1168: 	result = ast_utf8_replace_invalid_chars(new_value, &new_value_size,
How expensive of an operation is this?


File tests/test_json.c:

https://gerrit.asterisk.org/c/asterisk/+/19898/comment/8271d504_4669a9ce 
PS7, Line 1726: 				 "app_data", ""
This is a behavior change in the internal event, which can be used by things. Is it possible to maintain existing behavior?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19898
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I4ffbdb19c80bf0efc675d40078a3ca4f85c567d8
Gerrit-Change-Number: 19898
Gerrit-PatchSet: 7
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Tue, 28 Feb 2023 09:56:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230228/6bf1d3e6/attachment-0001.html>