[Asterisk-code-review] res/res_config_pgsql permit more than one database. (asterisk[20])

[N A]

Attention is currently required from: Joshua Colp, Eric Dantie.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19921 )

Change subject: res/res_config_pgsql permit more than one database.
......................................................................


Patch Set 7: Code-Review-1

(3 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/19921/comment/04f8b3a8_02058704 
PS3, Line 7: Add parameter dburl to res_config_pgsql to permit adding more than one database and parameters
> This is still not correct. […]
Still not quite there, something like this would be better:

res_config_pgsql: Permit more than one database.

Adds the dburl parameter to res_config_pgsql to permit adding
more than one database and parameters.

ASTERISK-30431

Make sure to line wrap the commit message around 72 characters.

This review is also still missing the CHANGES entry.


File res/res_config_pgsql.c:

https://gerrit.asterisk.org/c/asterisk/+/19921/comment/98682aae_155242b9 
PS7, Line 1464: 		ast_log(LOG_DEBUG,
Don't ast_log to LOG_DEBUG directly. Use the ast_debug macro.


https://gerrit.asterisk.org/c/asterisk/+/19921/comment/3358772c_2fe3f1c2 
PS7, Line 1468: 
Extra line is not needed here



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19921
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 20
Gerrit-Change-Id: I9ca8705c96acdd4a10989d981a5c2583a160aa44
Gerrit-Change-Number: 19921
Gerrit-PatchSet: 7
Gerrit-Owner: Eric Dantie <edantie at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Eric Dantie <edantie at gmail.com>
Gerrit-Comment-Date: Thu, 23 Feb 2023 19:20:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230223/bb7c718c/attachment.html>