<p> Attention is currently required from: Joshua Colp, Eric Dantie. </p>
<p>Patch set 7:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/19921">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19921/comment/04f8b3a8_02058704">Patch Set #3, Line 7:</a> <code style="font-family:monospace,monospace">Add parameter dburl to res_config_pgsql to permit adding more than one database and parameters</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">This is still not correct. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Still not quite there, something like this would be better:</p><p style="white-space: pre-wrap; word-wrap: break-word;">res_config_pgsql: Permit more than one database.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Adds the dburl parameter to res_config_pgsql to permit adding<br>more than one database and parameters.</p><p style="white-space: pre-wrap; word-wrap: break-word;">ASTERISK-30431</p><p style="white-space: pre-wrap; word-wrap: break-word;">Make sure to line wrap the commit message around 72 characters.</p><p style="white-space: pre-wrap; word-wrap: break-word;">This review is also still missing the CHANGES entry.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_config_pgsql.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19921/comment/98682aae_155242b9">Patch Set #7, Line 1464:</a> <code style="font-family:monospace,monospace">            ast_log(LOG_DEBUG,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Don't ast_log to LOG_DEBUG directly. Use the ast_debug macro.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19921/comment/3358772c_2fe3f1c2">Patch Set #7, Line 1468:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Extra line is not needed here</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/19921">change 19921</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/19921"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 20 </div>
<div style="display:none"> Gerrit-Change-Id: I9ca8705c96acdd4a10989d981a5c2583a160aa44 </div>
<div style="display:none"> Gerrit-Change-Number: 19921 </div>
<div style="display:none"> Gerrit-PatchSet: 7 </div>
<div style="display:none"> Gerrit-Owner: Eric Dantie <edantie@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-Attention: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: Eric Dantie <edantie@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 23 Feb 2023 19:20:37 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Comment-In-Reply-To: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>