[Asterisk-code-review] Add parameter dburl to res_config_pgsql to permit adding more than on... (asterisk[20])

[Joshua Colp]

Attention is currently required from: N A, Eric Dantie.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19921 )

Change subject: Add parameter dburl to res_config_pgsql to permit adding more than one database and parameters
......................................................................


Patch Set 3: Code-Review-1

(5 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/19921/comment/de232789_7c209c63 
PS3, Line 7: Add parameter dburl to res_config_pgsql to permit adding more than one database and parameters
Please see https://wiki.asterisk.org/wiki/display/AST/Commit+Messages for commit message writing.


Patchset:

PS3: 
Per my abandonment of the other review, the CHANGES should go here


File configs/samples/res_pgsql.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/19921/comment/3a5b2109_6d49027a 
PS3, Line 10: dburl=postgresql://127.0.0.1:5432/asterisk?target_session_attrs=any&application_name=asterisk
Is this a valid configuration? Both dburl and dbhost are now specified in this sample configuration


File res/res_config_pgsql.c:

https://gerrit.asterisk.org/c/asterisk/+/19921/comment/69a59e3f_c6de93ba 
PS3, Line 58: #define MAX_URL_OPTION_SIZE 256
Where does 256 come from?


https://gerrit.asterisk.org/c/asterisk/+/19921/comment/6cd838f1_01c91af3 
PS3, Line 1584: 		ast_debug(1, "pgsqlConn=%p\n", pgsqlConn);
This should be removed, it doesn't really help.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19921
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 20
Gerrit-Change-Id: I9ca8705c96acdd4a10989d981a5c2583a160aa44
Gerrit-Change-Number: 19921
Gerrit-PatchSet: 3
Gerrit-Owner: Eric Dantie <edantie at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Attention: Eric Dantie <edantie at gmail.com>
Gerrit-Comment-Date: Thu, 23 Feb 2023 11:44:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230223/dea233d4/attachment.html>