<p> Attention is currently required from: N A, Eric Dantie. </p>
<p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/19921">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19921/comment/de232789_7c209c63">Patch Set #3, Line 7:</a> <code style="font-family:monospace,monospace">Add parameter dburl to res_config_pgsql to permit adding more than one database and parameters</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Please see https://wiki.asterisk.org/wiki/display/AST/Commit+Messages for commit message writing.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">Patchset:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19921?tab=comments">Patch Set #3:</a> </p><p style="white-space: pre-wrap; word-wrap: break-word;">Per my abandonment of the other review, the CHANGES should go here</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File configs/samples/res_pgsql.conf.sample:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19921/comment/3a5b2109_6d49027a">Patch Set #3, Line 10:</a> <code style="font-family:monospace,monospace">dburl=postgresql://127.0.0.1:5432/asterisk?target_session_attrs=any&application_name=asterisk</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Is this a valid configuration? Both dburl and dbhost are now specified in this sample configuration</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_config_pgsql.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19921/comment/69a59e3f_c6de93ba">Patch Set #3, Line 58:</a> <code style="font-family:monospace,monospace">#define MAX_URL_OPTION_SIZE 256</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Where does 256 come from?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19921/comment/6cd838f1_01c91af3">Patch Set #3, Line 1584:</a> <code style="font-family:monospace,monospace">              ast_debug(1, "pgsqlConn=%p\n", pgsqlConn);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This should be removed, it doesn't really help.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/19921">change 19921</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/19921"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 20 </div>
<div style="display:none"> Gerrit-Change-Id: I9ca8705c96acdd4a10989d981a5c2583a160aa44 </div>
<div style="display:none"> Gerrit-Change-Number: 19921 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Eric Dantie <edantie@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-Attention: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-Attention: Eric Dantie <edantie@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 23 Feb 2023 11:44:16 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>