[Asterisk-code-review] voicemail.conf: Fix incorrect comment about #include. (asterisk[master])

[George Joseph]

George Joseph has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/20027 )

Change subject: voicemail.conf: Fix incorrect comment about #include.
......................................................................

voicemail.conf: Fix incorrect comment about #include.

A comment at the top of voicemail.conf says that #include
cannot be used in voicemail.conf because this breaks
the ability for app_voicemail to auto-update passwords.
This is factually incorrect, since Asterisk has no problem
updating files that are #include'd in the main configuration
file, and this does work in voicemail.conf as well.

ASTERISK-30479 #close

Change-Id: I3bf7d275849ab83f55f7fb6702a75a3077ee1df3
---
M configs/samples/voicemail.conf.sample
1 file changed, 26 insertions(+), 4 deletions(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved; Approved for Submit




diff --git a/configs/samples/voicemail.conf.sample b/configs/samples/voicemail.conf.sample
index e799cf6..8771bea 100644
--- a/configs/samples/voicemail.conf.sample
+++ b/configs/samples/voicemail.conf.sample
@@ -4,10 +4,14 @@
 
 ; ********* NOTICE ************************************************************
 ;
-; NOTE: Asterisk has to edit this file to change a user's password.  This does
-; not currently work with the "#include <file>" directive for Asterisk
-; configuration files, nor when using realtime static configuration.
-; Do not use them with this configuration file.
+; NOTE: Asterisk has to edit this file to change a user's password, so
+; do not use realtime static configuration with this file.
+; To avoid requiring config updates on password updates, you could use the
+; passwordlocation option to store passwords separately.
+;
+; If your "source of truth" for voicemail passwords is elsewhere, you should
+; use the externpassnotify option to notify whatever stores the passwords
+; (e.g. external database) when there are changes, to keep it synchronized.
 ;
 ; NOTE: Mailboxes defined by app_voicemail MUST be referenced by the rest
 ; of the system as mailbox at context.  The rest of the system cannot add

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/20027
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I3bf7d275849ab83f55f7fb6702a75a3077ee1df3
Gerrit-Change-Number: 20027
Gerrit-PatchSet: 4
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230410/d363a9ad/attachment.html>