<p>George Joseph <strong>submitted</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/20027">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span></span><br></pre><div style="white-space:pre-wrap">Approvals:
  Joshua Colp: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved; Approved for Submit

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">voicemail.conf: Fix incorrect comment about #include.<br><br>A comment at the top of voicemail.conf says that #include<br>cannot be used in voicemail.conf because this breaks<br>the ability for app_voicemail to auto-update passwords.<br>This is factually incorrect, since Asterisk has no problem<br>updating files that are #include'd in the main configuration<br>file, and this does work in voicemail.conf as well.<br><br>ASTERISK-30479 #close<br><br>Change-Id: I3bf7d275849ab83f55f7fb6702a75a3077ee1df3<br>---<br>M configs/samples/voicemail.conf.sample<br>1 file changed, 26 insertions(+), 4 deletions(-)<br><br></pre>
<pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/configs/samples/voicemail.conf.sample b/configs/samples/voicemail.conf.sample</span><br><span>index e799cf6..8771bea 100644</span><br><span>--- a/configs/samples/voicemail.conf.sample</span><br><span>+++ b/configs/samples/voicemail.conf.sample</span><br><span>@@ -4,10 +4,14 @@</span><br><span> </span><br><span> ; ********* NOTICE ************************************************************</span><br><span> ;</span><br><span style="color: hsl(0, 100%, 40%);">-; NOTE: Asterisk has to edit this file to change a user's password.  This does</span><br><span style="color: hsl(0, 100%, 40%);">-; not currently work with the "#include <file>" directive for Asterisk</span><br><span style="color: hsl(0, 100%, 40%);">-; configuration files, nor when using realtime static configuration.</span><br><span style="color: hsl(0, 100%, 40%);">-; Do not use them with this configuration file.</span><br><span style="color: hsl(120, 100%, 40%);">+; NOTE: Asterisk has to edit this file to change a user's password, so</span><br><span style="color: hsl(120, 100%, 40%);">+; do not use realtime static configuration with this file.</span><br><span style="color: hsl(120, 100%, 40%);">+; To avoid requiring config updates on password updates, you could use the</span><br><span style="color: hsl(120, 100%, 40%);">+; passwordlocation option to store passwords separately.</span><br><span style="color: hsl(120, 100%, 40%);">+;</span><br><span style="color: hsl(120, 100%, 40%);">+; If your "source of truth" for voicemail passwords is elsewhere, you should</span><br><span style="color: hsl(120, 100%, 40%);">+; use the externpassnotify option to notify whatever stores the passwords</span><br><span style="color: hsl(120, 100%, 40%);">+; (e.g. external database) when there are changes, to keep it synchronized.</span><br><span> ;</span><br><span> ; NOTE: Mailboxes defined by app_voicemail MUST be referenced by the rest</span><br><span> ; of the system as mailbox@context.  The rest of the system cannot add</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/20027">change 20027</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/20027"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3bf7d275849ab83f55f7fb6702a75a3077ee1df3 </div>
<div style="display:none"> Gerrit-Change-Number: 20027 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>