[Asterisk-code-review] res_config_pgsql: Permits more than one database and set parameters. (asterisk[master])

[Sean Bright]

Attention is currently required from: N A, George Joseph, Eric Dantie.

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19921 )

Change subject: res_config_pgsql: Permits more than one database and set parameters.
......................................................................


Patch Set 16: Code-Review-1

(1 comment)

Patchset:

PS16: 
So even though I know what is going on here I do think the commit message and CHANGES file are confusing. Other modules have the concept of "more than one database" but those are referring to logical database connections defined within Asterisk itself, e.g.:

```
[server1]
host = foo
schema = blah

[server2]
host = baz
schema = meh
```

So my suggestion is that the commit summary (the first line) just indicate that you've added support for PostgreSQL Connection URIs. Then in the body of the commit message and the CHANGES file, you can explain how that using a Connection URI allows you to configure multiple hosts, connection properties, etc.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19921
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I9ca8705c96acdd4a10989d981a5c2583a160aa44
Gerrit-Change-Number: 19921
Gerrit-PatchSet: 16
Gerrit-Owner: Eric Dantie <edantie at gmail.com>
Gerrit-Reviewer: Eric Dantie <edantie at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Eric Dantie <edantie at gmail.com>
Gerrit-Comment-Date: Mon, 03 Apr 2023 14:10:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230403/dbac6904/attachment.html>