[Asterisk-code-review] res_config_pgsql: Permits more than one database and set parameters. (asterisk[master])

[Eric Dantie]

Attention is currently required from: Sean Bright, N A, George Joseph.

Eric Dantie has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19921 )

Change subject: res_config_pgsql: Permits more than one database and set parameters.
......................................................................


Patch Set 16:

(1 comment)

Patchset:

PS15: 
> > Maybe it's just too early on a Monday morning but I don't understand how this "Permit[s] more than […]
Look on the postgresql documentation :
https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNSTRING

postgresql://host1:123,host2:456/somedb?target_session_attrs=any&application_name=myapp

You can specify more than one database so that if one is failing then it connects "transparently" to the others disponibles.
If your using a failover instances like https://github.com/citusdata/pg_auto_failover
you must specify all the databases so that if a database change from read/write to read only then you don't have to change the config of the asterisk realtime: it will be done automatically.

Maybe the title is not the best election: it's not writing/reading to every defined database, but it a single database with standbys which can be promoted to read/write at any time.


Hope that it will help understanding better the objective of this patch.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19921
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I9ca8705c96acdd4a10989d981a5c2583a160aa44
Gerrit-Change-Number: 19921
Gerrit-PatchSet: 16
Gerrit-Owner: Eric Dantie <edantie at gmail.com>
Gerrit-Reviewer: Eric Dantie <edantie at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 03 Apr 2023 12:04:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230403/1ba1e19f/attachment.html>