[Asterisk-code-review] res_pjsip_geolocation: Change some notices to debugs. (asterisk[master])

[George Joseph]

Attention is currently required from: N A.

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19305 )

Change subject: res_pjsip_geolocation: Change some notices to debugs.
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

File res/res_pjsip_geolocation.c:

https://gerrit.asterisk.org/c/asterisk/+/19305/comment/1cea75f7_60adbbd0 
PS1, Line 194: 			SCOPE_EXIT_LOG_RTN_VALUE(0, LOG_DEBUG, "%s: Endpoint has no geoloc_incoming_call_profile. "
> Thanks, that makes sense. I see all the SCOPE_EXIT have 0 as well, will this do debug level 0 (always log the debug message) or does some other level get used?
> 
> I would like it to be at least debug level 1, since I always have the debug level going to the console.

The "0" is the return value.  The debug value is the same as the trace level which is set in the initial SCOPE_ENTER macro.  In this case, "3".


File res/res_pjsip_geolocation.c:

https://gerrit.asterisk.org/c/asterisk/+/19305/comment/c383305c_9dfcd5cb 
PS2, Line 194: LOG_DEBUG, 
SCOPE_EXIT_RTN_VALUE doesn't take a LOG_ parameter.


https://gerrit.asterisk.org/c/asterisk/+/19305/comment/a5fa0a88_ae0cedd7 
PS2, Line 214: );
oops, I forgot to add the `, session_name);`.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19305
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I656b355d812f67cc0f0fdf09b00b0e1458598bb4
Gerrit-Change-Number: 19305
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Mon, 26 Sep 2022 12:46:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220926/d2017766/attachment-0001.html>