[Asterisk-code-review] res_pjsip_geolocation: Change some notices to debugs. (asterisk[master])

[N A]

Attention is currently required from: George Joseph.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19305 )

Change subject: res_pjsip_geolocation: Change some notices to debugs.
......................................................................


Patch Set 2:

(7 comments)

File res/res_pjsip_geolocation.c:

https://gerrit.asterisk.org/c/asterisk/+/19305/comment/35ec8d30_5513f689 
PS1, Line 148: 	RAII_VAR(struct ast_str *, buf, ast_str_create(1024), ast_free);
> While you're in this module could you fix this as well?  I shouldn't be allocating the buffer here w […]
Done


https://gerrit.asterisk.org/c/asterisk/+/19305/comment/88ae3d52_99f89deb 
PS1, Line 194: 			SCOPE_EXIT_LOG_RTN_VALUE(0, LOG_DEBUG, "%s: Endpoint has no geoloc_incoming_call_profile. "
> > Something odd here is if that if you use 1 instead 0, things behave as if an ast_channel_unref was […]
Thanks, that makes sense. I see all the SCOPE_EXIT have 0 as well, will this do debug level 0 (always log the debug message) or does some other level get used?

I would like it to be at least debug level 1, since I always have the debug level going to the console.


https://gerrit.asterisk.org/c/asterisk/+/19305/comment/8163220d_4db1399d 
PS1, Line 211: 
> Insert here... […]
Done


https://gerrit.asterisk.org/c/asterisk/+/19305/comment/273d466a_9834dd93 
PS1, Line 472: 	RAII_VAR(struct ast_str *, buf, ast_str_create(1024), ast_free);
> Change here as well.
Done


https://gerrit.asterisk.org/c/asterisk/+/19305/comment/d73d9607_a2cd3f5a 
PS1, Line 481: 	if (!buf) {
             : 		SCOPE_EXIT_LOG_RTN(LOG_WARNING, "%s: Unable to allocate buf\n",
             : 			session_name);
             : 	}
             : 
> and move this below where indicated.
Done


https://gerrit.asterisk.org/c/asterisk/+/19305/comment/2aff6e4b_915834ce 
PS1, Line 497: SCOPE_EXIT_LOG_RTN
> You can just all SCOPE_EXIT_RTN without the LOG.
Done


https://gerrit.asterisk.org/c/asterisk/+/19305/comment/5edb306e_d9b21278 
PS1, Line 580: 
> Add the ast_str_create and move the error check here. […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19305
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I656b355d812f67cc0f0fdf09b00b0e1458598bb4
Gerrit-Change-Number: 19305
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 26 Sep 2022 12:11:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220926/4e1515d5/attachment.html>