[Asterisk-code-review] tcptls: improve type-safety of periodic_fn callback argument. (asterisk[master])

Joshua Colp asteriskteam at digium.com
Tue Sep 6 08:19:28 CDT 2022


Attention is currently required from: Jaco Kroon.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19057 )

Change subject: tcptls: improve type-safety of periodic_fn callback argument.
......................................................................


Patch Set 1: Code-Review-2

(1 comment)

Patchset:

PS1: 
I agree with Sean Bright. This isn't hurting anything as-is, seems like change for the sake of change, and isn't really needed. If we replace this API then such things can be taken into account for the future.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19057
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I2279b8d7365eb7f9ae513caaf90333fffc53863e
Gerrit-Change-Number: 19057
Gerrit-PatchSet: 1
Gerrit-Owner: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Jaco Kroon <jaco at uls.co.za>
Gerrit-Comment-Date: Tue, 06 Sep 2022 13:19:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220906/5991e312/attachment.html>


More information about the asterisk-code-review mailing list