[Asterisk-code-review] tcptls: improve type-safety of periodic_fn callback argument. (asterisk[master])

[Jaco Kroon]

Attention is currently required from: Joshua Colp.

Jaco Kroon has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19057 )

Change subject: tcptls: improve type-safety of periodic_fn callback argument.
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1: 
> Why do the other functions remain unchanged? Did you look at history to see if there was any indicat […]
I was added (as far as I can tell) as part of commit b995c78c31a98e2f762d2a3006c27df14e9c5ede which does not provide details:

The comment in the include file is also inaccurate.

accept_fn is passed to ast_pthread_create_background, which expects a function pointer taking a void* argument, obviously I can cast it in tcptls.c there, or I can add to the comment that whilst it's a void* argument it really is a struct ast_tcptls_session_args*.  Which option would you prefer?

worker_fn is mostly trivial, except for chan_sip which is slightly more involved but not difficult (just not completely trivial).



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19057
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I2279b8d7365eb7f9ae513caaf90333fffc53863e
Gerrit-Change-Number: 19057
Gerrit-PatchSet: 1
Gerrit-Owner: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Tue, 06 Sep 2022 13:11:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220906/4759f898/attachment.html>