[Asterisk-code-review] res_pjsip: Add mediasec capabilities. (asterisk[16])

[Joshua Colp]

Attention is currently required from: N A, Maximilian Fridrich.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18837 )

Change subject: res_pjsip: Add mediasec capabilities.
......................................................................


Patch Set 8: Code-Review-1

(3 comments)

File res/res_pjsip_outbound_registration.c:

https://gerrit.asterisk.org/c/asterisk/+/18837/comment/3158f6ac_d2c00c7c 
PS8, Line 646: 		(endpt = ast_sorcery_retrieve_by_id(ast_sip_get_sorcery(), "endpoint", reg->endpoint)) &&
Does reg->endpoint have to be set on the outbound registration to work properly when security negotiation is enabled? If so, validation should be done on the outbound registration when applied to ensure that the configuration is valid. It doesn't need to verify that the endpoint exists, but it should verify that the name of one has been set in this scenario.


File res/res_pjsip_rfc3329.c:

https://gerrit.asterisk.org/c/asterisk/+/18837/comment/1573a9f1_f305f4c8 
PS8, Line 46: 
Should this be done if security negotiation isn't set?


File res/res_pjsip_session.c:

https://gerrit.asterisk.org/c/asterisk/+/18837/comment/09ecac51_7b86fdaf 
PS8, Line 4749: 						if ((tsx->status_code == 401 || tsx->status_code == 407 || tsx->status_code == 494)
If this is 494 but security negotiation isn't enabled, what is the result? Should it do this again at all?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18837
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ia7f5b5ba42db18074fdd5428c4e1838728586be2
Gerrit-Change-Number: 18837
Gerrit-PatchSet: 8
Gerrit-Owner: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Comment-Date: Tue, 06 Sep 2022 12:23:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220906/ea55a3c9/attachment.html>