[Asterisk-code-review] sipp_iterator: converting iterator into pluggable module (testsuite[18])

[George Joseph]

Attention is currently required from: Michael Bradeen.

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/testsuite/+/19462 )

Change subject: sipp_iterator: converting iterator into pluggable module
......................................................................


Patch Set 3: Code-Review-1

(3 comments)

File lib/python/asterisk/sipp_iterator.py:

https://gerrit.asterisk.org/c/testsuite/+/19462/comment/d1a2e7d0_0f85cae9 
PS3, Line 23:     scenarios:
            :         - {'Name': 'alice-registers.xml', 'port': '5061', 'target': '127.0.0.1', 'ordered-args': {'-aa'}}
            :         - {'Name': 'alice-is-notified-1.xml', 'port': '5061', 'target': '127.0.0.1'}
            :         - {'Name': 'alice-is-notified-2.xml', 'port': '5061', 'target': '127.0.0.1'}
            :         - {'Name': 'alice-is-notified-3.xml', 'port': '5061', 'target': '127.0.0.1'}
            :         - {'Name': 'alice-is-notified-4.xml', 'port': '5061', 'target': '127.0.0.1'}
            :         - {'Name': 'done'}
            :     actions:
            :         - {'Action': 'none'}
            :         - {'Action': 'MWIUpdate', 'Mailbox': 'alice', 'NewMessages':'2', 'OldMessages':'0'}
            :         - {'Action': 'MWIUpdate', 'Mailbox': 'alice', 'NewMessages':'1', 'OldMessages':'1'}
            :         - {'Action': 'MWIUpdate', 'Mailbox': 'alice', 'NewMessages':'0', 'OldMessages':'2'}
            :         - {'Action': 'MWIDelete', 'Mailbox': 'alice'}
            :         - {'Action': 'UserEvent', 'UserEvent': 'testComplete'}
            : 
I think it might be clearer to make this one list instead of two...

    scenarios:
        - { scenario: {}, action: {} }


https://gerrit.asterisk.org/c/testsuite/+/19462/comment/045287c3_5415959a 
PS3, Line 39:     scenarios:
            :         - {'Name': 'register', 'sequence': [
            :             {'Name': 'alice-registers.xml', 'port': '5061', 'target': '127.0.0.1', 'ordered-args': {'-aa'}},
            :             {'Name': 'bob-registers.xml', 'port': '5062', 'target': '127.0.0.1', 'ordered-args': {'-aa'}} ]}
            :         - {'Name': 'mailbox_a', 'sequence': [
            :             {'Name': 'alice-is-notified-1.xml', 'port': '5061', 'target': '127.0.0.1'},
            :             {'Name': 'bob-is-notified-1.xml', 'port': '5062', 'target': '127.0.0.1'} ]}
            :         - {'Name': 'mailbox_b', 'sequence': [
            :             {'Name': 'alice-is-notified-2.xml', 'port': '5061', 'target': '127.0.0.1'},
            :             {'Name': 'bob-is-notified-2.xml', 'port': '5062', 'target': '127.0.0.1'} ]}
            :         - {'Name': 'done'}
            : 
            :     actions:
            :         - {'Messages': [
            :             {'Action': 'UserEvent', 'UserEvent': 'testStarted'} ]}
            :         - {'Messages': [
            :             {'Action': 'MWIUpdate', 'Mailbox': 'mailbox_a', 'NewMessages':'2', 'OldMessages':'1'} ]}
            :         - {'Messages': [
            :             {'Action': 'MWIUpdate', 'Mailbox': 'mailbox_b', 'NewMessages':'3', 'OldMessages':'3'} ]}
            :         - {'Messages': [
            :             {'Action': 'UserEvent', 'UserEvent': 'testComplete'} ]}
            : 
Same here


https://gerrit.asterisk.org/c/testsuite/+/19462/comment/5c8ceef5_3f629390 
PS3, Line 78: 
An actual sequence description would be good for both types for instance for multi...

Start alice-registers.xml
Start bob-registers.,xml
Send Userevent testStarted
Wait for both alice-registers and bob-registers to finish.
Start alice-is-notified-1.xml
...



-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/19462
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 18
Gerrit-Change-Id: I57ed85d2a2a044207da23a750e433dcc38eb93ff
Gerrit-Change-Number: 19462
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Comment-Date: Mon, 31 Oct 2022 13:57:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221031/0e0ab206/attachment.html>