<p> Attention is currently required from: Michael Bradeen. </p>
<p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/testsuite/+/19462">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File lib/python/asterisk/sipp_iterator.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/19462/comment/d1a2e7d0_0f85cae9">Patch Set #3, Line 23:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> scenarios:<br> - {'Name': 'alice-registers.xml', 'port': '5061', 'target': '127.0.0.1', 'ordered-args': {'-aa'}}<br> - {'Name': 'alice-is-notified-1.xml', 'port': '5061', 'target': '127.0.0.1'}<br> - {'Name': 'alice-is-notified-2.xml', 'port': '5061', 'target': '127.0.0.1'}<br> - {'Name': 'alice-is-notified-3.xml', 'port': '5061', 'target': '127.0.0.1'}<br> - {'Name': 'alice-is-notified-4.xml', 'port': '5061', 'target': '127.0.0.1'}<br> - {'Name': 'done'}<br> actions:<br> - {'Action': 'none'}<br> - {'Action': 'MWIUpdate', 'Mailbox': 'alice', 'NewMessages':'2', 'OldMessages':'0'}<br> - {'Action': 'MWIUpdate', 'Mailbox': 'alice', 'NewMessages':'1', 'OldMessages':'1'}<br> - {'Action': 'MWIUpdate', 'Mailbox': 'alice', 'NewMessages':'0', 'OldMessages':'2'}<br> - {'Action': 'MWIDelete', 'Mailbox': 'alice'}<br> - {'Action': 'UserEvent', 'UserEvent': 'testComplete'}<br><br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think it might be clearer to make this one list instead of two...</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> scenarios:<br> - { scenario: {}, action: {} }</pre></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/19462/comment/045287c3_5415959a">Patch Set #3, Line 39:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> scenarios:<br> - {'Name': 'register', 'sequence': [<br> {'Name': 'alice-registers.xml', 'port': '5061', 'target': '127.0.0.1', 'ordered-args': {'-aa'}},<br> {'Name': 'bob-registers.xml', 'port': '5062', 'target': '127.0.0.1', 'ordered-args': {'-aa'}} ]}<br> - {'Name': 'mailbox_a', 'sequence': [<br> {'Name': 'alice-is-notified-1.xml', 'port': '5061', 'target': '127.0.0.1'},<br> {'Name': 'bob-is-notified-1.xml', 'port': '5062', 'target': '127.0.0.1'} ]}<br> - {'Name': 'mailbox_b', 'sequence': [<br> {'Name': 'alice-is-notified-2.xml', 'port': '5061', 'target': '127.0.0.1'},<br> {'Name': 'bob-is-notified-2.xml', 'port': '5062', 'target': '127.0.0.1'} ]}<br> - {'Name': 'done'}<br><br> actions:<br> - {'Messages': [<br> {'Action': 'UserEvent', 'UserEvent': 'testStarted'} ]}<br> - {'Messages': [<br> {'Action': 'MWIUpdate', 'Mailbox': 'mailbox_a', 'NewMessages':'2', 'OldMessages':'1'} ]}<br> - {'Messages': [<br> {'Action': 'MWIUpdate', 'Mailbox': 'mailbox_b', 'NewMessages':'3', 'OldMessages':'3'} ]}<br> - {'Messages': [<br> {'Action': 'UserEvent', 'UserEvent': 'testComplete'} ]}<br><br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same here</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/19462/comment/5c8ceef5_3f629390">Patch Set #3, Line 78:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">An actual sequence description would be good for both types for instance for multi...</p><p style="white-space: pre-wrap; word-wrap: break-word;">Start alice-registers.xml<br>Start bob-registers.,xml<br>Send Userevent testStarted<br>Wait for both alice-registers and bob-registers to finish.<br>Start alice-is-notified-1.xml<br>...</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/testsuite/+/19462">change 19462</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/testsuite/+/19462"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: 18 </div>
<div style="display:none"> Gerrit-Change-Id: I57ed85d2a2a044207da23a750e433dcc38eb93ff </div>
<div style="display:none"> Gerrit-Change-Number: 19462 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-Attention: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 31 Oct 2022 13:57:06 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>