[Asterisk-code-review] Dialing API: Cancel a running async thread, may not cancel all calls (asterisk[18])

[N A]

Attention is currently required from: Frederic LE FOLL.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19409 )

Change subject: Dialing API: Cancel a running async thread, may not cancel all calls
......................................................................


Patch Set 1: -Code-Review

(1 comment)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/19409/comment/997dee92_483bba03 
PS1, Line 7: Dialing API: Cancel a running async thread, may not cancel all calls
> The problem occurs in main/dial.c, aka "Dialing API" according to dial.h. Not in app_dial. […]
Ah, sorry, I misread "main/dial.c" as "app_dial.c" in the file list. You can ignore that.

Convention wise though using "dial" or "dial.c" might adhere to the commit message guidelines better but it's be less clear cut (lowercase, typically the name of the module or file)



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19409
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Idbdd5c15122159661aa8e996a42d5800083131e4
Gerrit-Change-Number: 19409
Gerrit-PatchSet: 1
Gerrit-Owner: Frederic LE FOLL <frederic.lefoll at csgroup.eu>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Frederic LE FOLL <frederic.lefoll at csgroup.eu>
Gerrit-Comment-Date: Thu, 06 Oct 2022 17:18:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Frederic LE FOLL <frederic.lefoll at csgroup.eu>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221006/9f8585b4/attachment-0001.html>