[Asterisk-code-review] Dialing API: Cancel a running async thread, may not cancel all calls (asterisk[18])

[Frederic LE FOLL]

Attention is currently required from: N A.

Frederic LE FOLL has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19409 )

Change subject: Dialing API: Cancel a running async thread, may not cancel all calls
......................................................................


Patch Set 1:

(1 comment)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/19409/comment/1b231ef6_24b0a1df 
PS1, Line 7: Dialing API: Cancel a running async thread, may not cancel all calls
> Use app_dial instead of Dialing API, that is more accurate
The problem occurs in main/dial.c, aka "Dialing API" according to dial.h. Not in app_dial.

I observed the problem while using Page application (app_page) but my understanding is that the cause is located in dial.c:ast_dial_join().



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19409
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Idbdd5c15122159661aa8e996a42d5800083131e4
Gerrit-Change-Number: 19409
Gerrit-PatchSet: 1
Gerrit-Owner: Frederic LE FOLL <frederic.lefoll at csgroup.eu>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Thu, 06 Oct 2022 17:16:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221006/1588808c/attachment.html>