[Asterisk-code-review] app_voicemail_odbc: Fix string overflow warning. (asterisk[master])

N A asteriskteam at digium.com
Mon Nov 28 19:24:23 CST 2022


Attention is currently required from: N A.

Hello Joshua Colp, Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/19563

to look at the new patch set (#2).

Change subject: app_voicemail_odbc: Fix string overflow warning.
......................................................................

app_voicemail_odbc: Fix string overflow warning.

When using ast_copy_string, gcc complains about
a potential negative offset, so use strncpy instead.

Additionally, although it doesn't currently complain
about it, the size of a buffer is increased to
accomodate the maximum size contents it could have.

ASTERISK-30240 #close

Change-Id: I8eecedf14d3f2a75864797f802277cac89a32877
---
M apps/app_voicemail.c
1 file changed, 24 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/63/19563/2
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19563
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I8eecedf14d3f2a75864797f802277cac89a32877
Gerrit-Change-Number: 19563
Gerrit-PatchSet: 2
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221129/0011315b/attachment.html>


More information about the asterisk-code-review mailing list