[Asterisk-code-review] app_voicemail_odbc: Fix string overflow warning. (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19563 )

Change subject: app_voicemail_odbc: Fix string overflow warning.
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

File apps/app_voicemail.c:

https://gerrit.asterisk.org/c/asterisk/+/19563/comment/0a39a6d8_21b2b151 
PS1, Line 4492: 		ast_copy_string(fn, dir, sizeof(fn));
GCC complains about negative offset, but do we understand why it's doing that? Is it actually possible?


https://gerrit.asterisk.org/c/asterisk/+/19563/comment/8ab540fd_8e63e2b7 
PS1, Line 4485: 	char full_fn[PATH_MAX + 4];
Why + 4?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19563
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I8eecedf14d3f2a75864797f802277cac89a32877
Gerrit-Change-Number: 19563
Gerrit-PatchSet: 1
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Comment-Date: Thu, 24 Nov 2022 10:51:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221124/b3c4f136/attachment.html>