[Asterisk-code-review] res_pjsip_session: Use Caller ID for extension matching. (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19604 )

Change subject: res_pjsip_session: Use Caller ID for extension matching.
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1: 
> I don't agree with adding it as a now mandatory depedency or making those symbols global. […]
How would that solve the problem exactly? The supplement doesn't execute until after the relevant INVITE handling, so waiting for res_pjsip_caller_id to do its thing won't work. It already does populate when a channel is not present, but that doesn't help us here.

If we don't want to make it mandatory, then could the functions that parse the Caller ID from the session and rdata be moved to res_pjsip?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19604
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iec7f5a3b90e51b65ccf74342f96bf80314b7cfc7
Gerrit-Change-Number: 19604
Gerrit-PatchSet: 1
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Sat, 26 Nov 2022 19:10:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221126/2fd396ec/attachment-0001.html>