[Asterisk-code-review] res_pjsip_session: Use Caller ID for extension matching. (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19604 )

Change subject: res_pjsip_session: Use Caller ID for extension matching.
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1: 
> (and export global symbols in res_pjsip_callerid, obviously)
I don't agree with adding it as a now mandatory depedency or making those symbols global. I think session should have a callerid field on it, like was done for exten, that res_pjsip_callerid can populate early if a channel is not present. This can then be used here and elsewhere.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19604
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iec7f5a3b90e51b65ccf74342f96bf80314b7cfc7
Gerrit-Change-Number: 19604
Gerrit-PatchSet: 1
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Comment-Date: Sat, 26 Nov 2022 19:07:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221126/8313b401/attachment.html>