[Asterisk-code-review] res_pjsip_session: Use Caller ID for extension matching. (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19604 )

Change subject: res_pjsip_session: Use Caller ID for extension matching.
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1: 
> This effectively duplicates the logic in two places, which is two places to now maintain, and if som […]
Would you be fine with making these public res_pjsip functions? I think that'd be the only way.

res_pjsip_callerid doesn't export global symbols, so they can't be made public from there. Alternately, we could make res_pjsip_session depend on res_pjsip_callerid and then just make it public from there.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19604
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iec7f5a3b90e51b65ccf74342f96bf80314b7cfc7
Gerrit-Change-Number: 19604
Gerrit-PatchSet: 1
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Sat, 26 Nov 2022 18:32:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221126/ce4cec56/attachment.html>