[Asterisk-code-review] res_pjsip_session: Use Caller ID for extension matching. (asterisk[master])

Joshua Colp asteriskteam at digium.com
Sat Nov 26 07:41:28 CST 2022


Attention is currently required from: N A.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19604 )

Change subject: res_pjsip_session: Use Caller ID for extension matching.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Patchset:

PS1: 
This effectively duplicates the logic in two places, which is two places to now maintain, and if something changes and one side is forgotten then behavior drifts. This should be fixed such that the logic remains in one place. I don't know what that looks like, as I haven't investigated fixing this issue.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19604
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iec7f5a3b90e51b65ccf74342f96bf80314b7cfc7
Gerrit-Change-Number: 19604
Gerrit-PatchSet: 1
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Comment-Date: Sat, 26 Nov 2022 13:41:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221126/0734174f/attachment-0001.html>


More information about the asterisk-code-review mailing list