[Asterisk-code-review] channel.c: Preserve tone playback on masquerades. (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19572 )

Change subject: channel.c: Preserve tone playback on masquerades.
......................................................................


Patch Set 1:

(1 comment)

File main/channel.c:

https://gerrit.asterisk.org/c/asterisk/+/19572/comment/c83c609e_8a2824e2 
PS1, Line 7154: 		 * then it makes sense to move the generator over.
> Furthermore, not sure what bug that review is referencing, but it doesn't seem to align with JIRA is […]
No, I don't remember. I'm just concerned that something like this would have unintended consequences due to the fact that it's been this way for so long. We've seen with other changes in legacy code that regressions have occurred as a result of fixing a particular case.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19572
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4753d465bd4d5bb7fe205918e0f22b95a5e869e1
Gerrit-Change-Number: 19572
Gerrit-PatchSet: 1
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Comment-Date: Thu, 24 Nov 2022 15:26:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221124/3ada71aa/attachment.html>