[Asterisk-code-review] channel.c: Preserve tone playback on masquerades. (asterisk[master])

N A asteriskteam at digium.com
Thu Nov 24 09:22:13 CST 2022


Attention is currently required from: Joshua Colp.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19572 )

Change subject: channel.c: Preserve tone playback on masquerades.
......................................................................


Patch Set 1:

(1 comment)

File main/channel.c:

https://gerrit.asterisk.org/c/asterisk/+/19572/comment/6bd96d55_ee157afd 
PS1, Line 7154: 		 * then it makes sense to move the generator over.
> This is the commit that introduced this regression: https://github. […]
Furthermore, not sure what bug that review is referencing, but it doesn't seem to align with JIRA issues, this is unrelated: https://issues.asterisk.org/jira/browse/ASTERISK-4584



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19572
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4753d465bd4d5bb7fe205918e0f22b95a5e869e1
Gerrit-Change-Number: 19572
Gerrit-PatchSet: 1
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 24 Nov 2022 15:22:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221124/61dce375/attachment.html>


More information about the asterisk-code-review mailing list