[Asterisk-code-review] res_pjsip_rfc3326: Add SIP causes support for RFC3326 (asterisk[18])

[Igor Goncharovsky]

Attention is currently required from: N A.

Igor Goncharovsky has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19570 )

Change subject: res_pjsip_rfc3326: Add SIP causes support for RFC3326
......................................................................


Patch Set 2:

(5 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/19570/comment/758aa52d_f51575f8 
PS2, Line 9: Add ability to set HANGUPCAUSE when SIP causecode sent in BYE (additionally to currently supported Q.850).
> "in addition to" would be clearer, actually
Ack


Patchset:

PS2: 
Thanks! Fixes uploaded


File include/asterisk/res_pjsip.h:

https://gerrit.asterisk.org/c/asterisk/+/19570/comment/558b8d17_598619b5 
PS2, Line 3913: /*! 
> trailing whitespace
Ack


https://gerrit.asterisk.org/c/asterisk/+/19570/comment/060ac7cd_5716a470 
PS2, Line 3914:  * \brief Convert SIP hangup causes to Asterisk hangup causes 
> trailing whitespace
Ack


https://gerrit.asterisk.org/c/asterisk/+/19570/comment/a857e2c4_efb67cc8 
PS2, Line 3920: const int hangup_sip2cause(int cause);
> Since this is a public API, should it have an appropriate prefix (e.g. […]
Ack



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19570
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I3f55622dc680ce713a2ffb5a458ef5dd39fcf645
Gerrit-Change-Number: 19570
Gerrit-PatchSet: 2
Gerrit-Owner: Igor Goncharovsky <igor.goncharovsky at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Comment-Date: Sun, 20 Nov 2022 14:00:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221120/9d950b38/attachment-0001.html>