[Asterisk-code-review] res_pjsip_rfc3326: Add SIP causes support for RFC3326 (asterisk[18])

[N A]

Attention is currently required from: Igor Goncharovsky.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19570 )

Change subject: res_pjsip_rfc3326: Add SIP causes support for RFC3326
......................................................................


Patch Set 2: Code-Review-1

(4 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/19570/comment/a306d6d5_cc0c439e 
PS2, Line 9: Add ability to set HANGUPCAUSE when SIP causecode sent in BYE (additionally to currently supported Q.850).
"in addition to" would be clearer, actually


File include/asterisk/res_pjsip.h:

https://gerrit.asterisk.org/c/asterisk/+/19570/comment/206f80bd_3eeed6d0 
PS2, Line 3913: /*! 
trailing whitespace


https://gerrit.asterisk.org/c/asterisk/+/19570/comment/899db1ab_5578eb57 
PS2, Line 3914:  * \brief Convert SIP hangup causes to Asterisk hangup causes 
trailing whitespace


https://gerrit.asterisk.org/c/asterisk/+/19570/comment/4b7b18a8_cd2fd1a6 
PS2, Line 3920: const int hangup_sip2cause(int cause);
Since this is a public API, should it have an appropriate prefix (e.g. ast_sip_hangup_sip2cause)?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19570
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I3f55622dc680ce713a2ffb5a458ef5dd39fcf645
Gerrit-Change-Number: 19570
Gerrit-PatchSet: 2
Gerrit-Owner: Igor Goncharovsky <igor.goncharovsky at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Igor Goncharovsky <igor.goncharovsky at gmail.com>
Gerrit-Comment-Date: Sat, 19 Nov 2022 19:42:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221119/c9eee0bc/attachment.html>