[Asterisk-code-review] chan_alsa: Remove deprecated module. (asterisk[master])

[N A]

Attention is currently required from: Michael Bradeen, Joshua Colp.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19564 )

Change subject: chan_alsa: Remove deprecated module.
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

File channels/chan_console.c:

https://gerrit.asterisk.org/c/asterisk/+/19564/comment/adb58174_0dea5f6b 
PS2, Line 38:  * including ALSA and OSS, may replace the deprecated chan_alsa and chan_oss.
This is still forward looking verbiage, even though it's already happened.
I would just say ", this has replaced chan_alsa and chan_oss"


https://gerrit.asterisk.org/c/asterisk/+/19564/comment/492b1ed8_a2b91bf0 
PS2, Line 39:  * However, before that can be done, it needs to *at least* have all of the
Since this has been done anyways, I think this comment should be updated to make it clear that chan_alsa and chan_oss may have had some of these capabilities that are not yet in chan_console (if that is the case). That way it's clear to a developer they may still need to be implemented.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19564
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I5c8afb781528afdf55d237e3bffa5e4a862ae8c7
Gerrit-Change-Number: 19564
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Tue, 15 Nov 2022 21:49:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221115/b461f4ce/attachment.html>