<p> Attention is currently required from: Michael Bradeen, Joshua Colp. </p>
<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/19564">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File channels/chan_console.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19564/comment/adb58174_0dea5f6b">Patch Set #2, Line 38:</a> <code style="font-family:monospace,monospace"> * including ALSA and OSS, may replace the deprecated chan_alsa and chan_oss.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This is still forward looking verbiage, even though it's already happened.<br>I would just say ", this has replaced chan_alsa and chan_oss"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19564/comment/492b1ed8_a2b91bf0">Patch Set #2, Line 39:</a> <code style="font-family:monospace,monospace"> * However, before that can be done, it needs to *at least* have all of the</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Since this has been done anyways, I think this comment should be updated to make it clear that chan_alsa and chan_oss may have had some of these capabilities that are not yet in chan_console (if that is the case). That way it's clear to a developer they may still need to be implemented.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/19564">change 19564</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/19564"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5c8afb781528afdf55d237e3bffa5e4a862ae8c7 </div>
<div style="display:none"> Gerrit-Change-Number: 19564 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-CC: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 15 Nov 2022 21:49:30 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>