[Asterisk-code-review] translate.c: Prefer better codecs upon translate ties. (asterisk[master])

[N A]

Attention is currently required from: Greg Brown, Joshua Colp, George Joseph, Kevin Harwell.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15953 )

Change subject: translate.c: Prefer better codecs upon translate ties.
......................................................................


Patch Set 9:

(1 comment)

Patchset:

PS6: 
> I was not clear enough. The "quality" var being hard coded would be better in codecs. […]
If you read up this thread, Josh mentioned earlier that codecs.conf is a separate thing not used for codecs generically.

I don't really see the point in allowing users to rank codecs. There's nothing to be gain by setting gsm to better than ulaw, for example, it would just expose something that to me does not make sense for users to mess with, since codecs have an objective ordering for quality. Your "hack" can still be done by modifying source of course, whereas before it was not changeable, though I can't think why anyone would do it.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15953
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4b7297e1baca7aac14fe4a3c7538e18e2dbe9fd6
Gerrit-Change-Number: 15953
Gerrit-PatchSet: 9
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <default.enum at gmail.com>
Gerrit-CC: Greg Brown <gbrown1002000 at yahoo.com>
Gerrit-Attention: Greg Brown <gbrown1002000 at yahoo.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Kevin Harwell <default.enum at gmail.com>
Gerrit-Comment-Date: Thu, 03 Nov 2022 20:59:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Greg Brown <gbrown1002000 at yahoo.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221103/2c584821/attachment.html>