[Asterisk-code-review] translate.c: Prefer better codecs upon translate ties. (asterisk[master])

[Greg Brown]

Attention is currently required from: N A, Joshua Colp, George Joseph, Kevin Harwell.

Greg Brown has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15953 )

Change subject: translate.c: Prefer better codecs upon translate ties.
......................................................................


Patch Set 9:

(2 comments)

Patchset:

PS6: 
> That is codec negotiation order, which is not applicable here.
I was not clear enough. The "quality" var being hard coded would be better in codecs.conf so people could rank them without editing/compiling.
I'm okay with it as is though.
It could become a favorite hack. For example move Opus up for HD voice.


Patchset:

PS9: 
I was not clear enough. The "quality" var being hard coded would be better in codecs.conf so people could rank them without editing/compiling.
I'm okay with it as is though.
It could become a popular hack. For example move Opus up the rank for HD voice.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15953
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4b7297e1baca7aac14fe4a3c7538e18e2dbe9fd6
Gerrit-Change-Number: 15953
Gerrit-PatchSet: 9
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <default.enum at gmail.com>
Gerrit-CC: Greg Brown <gbrown1002000 at yahoo.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Kevin Harwell <default.enum at gmail.com>
Gerrit-Comment-Date: Thu, 03 Nov 2022 20:41:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Greg Brown <gbrown1002000 at yahoo.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221103/09746fe7/attachment.html>