[Asterisk-code-review] res_pjsip_aoc: New module for sending advice-of-charge with chan_pjsip (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A, Michael Kuron.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19460 )

Change subject: res_pjsip_aoc: New module for sending advice-of-charge with chan_pjsip
......................................................................


Patch Set 9: Code-Review-1

(3 comments)

File configs/samples/pjsip.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/19460/comment/fcf780ec_a8e5daf2 
PS8, Line 969:                 ; (default: no)
> Correct, it allows chan_pjsip to send out AOC-S messages (which chan_sip did not do), but there is c […]
That would be best as a separate patch.


File doc/CHANGES-staging/res_pjsip_aoc.txt:

https://gerrit.asterisk.org/c/asterisk/+/19460/comment/dba103c1_f45d8fe3 
PS9, Line 3: Added res_pjsip_aoc which gives chan_pjsip the ability to send Advice-of-Charge messages
Document in here that it is controlled using the "send_aoc" option on the endpoint.


File res/res_pjsip_session.c:

https://gerrit.asterisk.org/c/asterisk/+/19460/comment/dde732e7_a138b810 
PS9, Line 4280: 		handle_outgoing_response(session, tdata);
This is currently done by the ast_sip_session_send_response function. Does this mean this will be called twice for some responses? Should it be removed from that function, and if so - what impact does that have?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19460
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iebb7ad0d5f88526bc6629d3a1f9f11665434d333
Gerrit-Change-Number: 19460
Gerrit-PatchSet: 9
Gerrit-Owner: Michael Kuron <m.kuron at gmx.de>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Attention: Michael Kuron <m.kuron at gmx.de>
Gerrit-Comment-Date: Tue, 01 Nov 2022 14:34:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Comment-In-Reply-To: Michael Kuron <m.kuron at gmx.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221101/82a1957b/attachment-0001.html>