<p> Attention is currently required from: N A, Michael Kuron. </p>
<p>Patch set 9:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/19460">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File configs/samples/pjsip.conf.sample:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19460/comment/fcf780ec_a8e5daf2">Patch Set #8, Line 969:</a> <code style="font-family:monospace,monospace">                ; (default: no)</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Correct, it allows chan_pjsip to send out AOC-S messages (which chan_sip did not do), but there is c […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">That would be best as a separate patch.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File doc/CHANGES-staging/res_pjsip_aoc.txt:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19460/comment/dba103c1_f45d8fe3">Patch Set #9, Line 3:</a> <code style="font-family:monospace,monospace">Added res_pjsip_aoc which gives chan_pjsip the ability to send Advice-of-Charge messages</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Document in here that it is controlled using the "send_aoc" option on the endpoint.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_pjsip_session.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19460/comment/dde732e7_a138b810">Patch Set #9, Line 4280:</a> <code style="font-family:monospace,monospace">               handle_outgoing_response(session, tdata);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This is currently done by the ast_sip_session_send_response function. Does this mean this will be called twice for some responses? Should it be removed from that function, and if so - what impact does that have?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/19460">change 19460</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/19460"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iebb7ad0d5f88526bc6629d3a1f9f11665434d333 </div>
<div style="display:none"> Gerrit-Change-Number: 19460 </div>
<div style="display:none"> Gerrit-PatchSet: 9 </div>
<div style="display:none"> Gerrit-Owner: Michael Kuron <m.kuron@gmx.de> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-Attention: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-Attention: Michael Kuron <m.kuron@gmx.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 01 Nov 2022 14:34:15 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Comment-In-Reply-To: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Comment-In-Reply-To: Michael Kuron <m.kuron@gmx.de> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>