[Asterisk-code-review] app_dial: Fix dial status regression. (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp, George Joseph.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18521 )

Change subject: app_dial: Fix dial status regression.
......................................................................


Patch Set 4:

(1 comment)

File apps/app_dial.c:

https://gerrit.asterisk.org/c/asterisk/+/18521/comment/c63b8db7_129d5bc7 
PS4, Line 2842: 	if (!num_dialed) {
> I didn't need an explanation or anything, just confirmation that the behavior before and after is eq […]
Behavior is equivalent:

BEFORE:
[2022-05-31 12:14:46]     -- Executing [s at t3:1] Dial("Local/s at t3-00000068;2", "PJSIP/test&&PJSIP/test2&&Local/s at d1&&Local/s at d2") in new stack
[2022-05-31 12:14:46] ERROR[29282]: chan_pjsip.c:2712 request: Unable to create PJSIP channel - endpoint 'test' was not found
[2022-05-31 12:14:46] WARNING[25307][C-0000002d]: app_dial.c:2666 dial_exec_full: Unable to create channel of type 'PJSIP' (cause 3 - No route to destination)
[2022-05-31 12:14:46] ERROR[28091]: chan_pjsip.c:2712 request: Unable to create PJSIP channel - endpoint 'test2' was not found
[2022-05-31 12:14:46] WARNING[25307][C-0000002d]: app_dial.c:2666 dial_exec_full: Unable to create channel of type 'PJSIP' (cause 3 - No route to destination)
[2022-05-31 12:14:46]     -- Called Local/s at d1
[2022-05-31 12:14:46]     -- Called Local/s at d2
[2022-05-31 12:14:46]     -- Executing [s at d1:1] Hangup("Local/s at d1-00000069;2", "") in new stack
[2022-05-31 12:14:46]   == Spawn extension (d1, s, 1) exited non-zero on 'Local/s at d1-00000069;2'
[2022-05-31 12:14:46]     -- Executing [s at d2:1] Hangup("Local/s at d2-0000006a;2", "") in new stack
[2022-05-31 12:14:46]   == Spawn extension (d2, s, 1) exited non-zero on 'Local/s at d2-0000006a;2'
[2022-05-31 12:14:46]     -- No one is available to answer at this time (4:0/0/2)
[2022-05-31 12:14:46]     -- Auto fallthrough, channel 'Local/s at t3-00000068;2' status is 'NOANSWER'


AFTER:
[2022-05-31 12:15:08]     -- Executing [s at t3:1] Dial("Local/s at t3-0000006b;2", "PJSIP/test&&PJSIP/test2&&Local/s at d1&&Local/s at d2") in new stack
[2022-05-31 12:15:08] ERROR[29282]: chan_pjsip.c:2712 request: Unable to create PJSIP channel - endpoint 'test' was not found
[2022-05-31 12:15:08] NOTICE[25342][C-0000002e]: app_dial.c:2667 dial_exec_full: Unable to create channel of type 'PJSIP' (cause 3 - No route to destination)
[2022-05-31 12:15:08] ERROR[28091]: chan_pjsip.c:2712 request: Unable to create PJSIP channel - endpoint 'test2' was not found
[2022-05-31 12:15:08] NOTICE[25342][C-0000002e]: app_dial.c:2667 dial_exec_full: Unable to create channel of type 'PJSIP' (cause 3 - No route to destination)
[2022-05-31 12:15:08]     -- Called Local/s at d1
[2022-05-31 12:15:08]     -- Called Local/s at d2
[2022-05-31 12:15:08]     -- Executing [s at d2:1] Hangup("Local/s at d2-0000006d;2", "") in new stack
[2022-05-31 12:15:08]   == Spawn extension (d2, s, 1) exited non-zero on 'Local/s at d2-0000006d;2'
[2022-05-31 12:15:08]     -- Executing [s at d1:1] Hangup("Local/s at d1-0000006c;2", "") in new stack
[2022-05-31 12:15:08]   == Spawn extension (d1, s, 1) exited non-zero on 'Local/s at d1-0000006c;2'
[2022-05-31 12:15:08]     -- No one is available to answer at this time (4:0/0/2)
[2022-05-31 12:15:08]     -- Auto fallthrough, channel 'Local/s at t3-0000006b;2' status is 'NOANSWER'



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18521
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4d4b209b967816b1bc791534593ababa2b99bb88
Gerrit-Change-Number: 18521
Gerrit-PatchSet: 4
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Tue, 31 May 2022 12:16:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220531/ebef229b/attachment-0001.html>