[Asterisk-code-review] app_dial: Fix dial status regression. (asterisk[master])

Joshua Colp asteriskteam at digium.com
Tue May 31 06:53:11 CDT 2022


Attention is currently required from: N A, George Joseph.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18521 )

Change subject: app_dial: Fix dial status regression.
......................................................................


Patch Set 4:

(1 comment)

File apps/app_dial.c:

https://gerrit.asterisk.org/c/asterisk/+/18521/comment/4957caf3_aea5afc0 
PS4, Line 2842: 	if (!num_dialed) {
> In fact, it's more liberal than before, because before it was using AST_LIST_SIZE and erroring out o […]
I didn't need an explanation or anything, just confirmation that the behavior before and after is equivalent. I'd still like to see confirmation of the output before and after though.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18521
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4d4b209b967816b1bc791534593ababa2b99bb88
Gerrit-Change-Number: 18521
Gerrit-PatchSet: 4
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Tue, 31 May 2022 11:53:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220531/2170478f/attachment.html>


More information about the asterisk-code-review mailing list