[Asterisk-code-review] pbx: Add pbx exec helper function. (asterisk[master])

N A asteriskteam at digium.com
Tue May 31 06:09:22 CDT 2022


Attention is currently required from: Joshua Colp.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18562 )

Change subject: pbx: Add pbx exec helper function.
......................................................................


Patch Set 1:

(1 comment)

File include/asterisk/pbx.h:

https://gerrit.asterisk.org/c/asterisk/+/18562/comment/9ab7c832_5bcf7b16 
PS1, Line 284: int pbx_exec_helper(struct ast_channel *chan, const char *app_name, const char *app_args);
> Current functions added should be prefixed with ast_, I also think this could be better named. […]
I only did pbx for consistency since that part of the code uses pbx.
Seems like having both the ast and pbx prefixes would be confusing; at least, I don't recall seeing that before.

What about ast_application_exec ?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18562
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ifee4d2825df7545fb515d763d393065675140c84
Gerrit-Change-Number: 18562
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Tue, 31 May 2022 11:09:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220531/a367cd71/attachment.html>


More information about the asterisk-code-review mailing list