[Asterisk-code-review] pbx: Add pbx exec helper function. (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18562 )

Change subject: pbx: Add pbx exec helper function.
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

File include/asterisk/pbx.h:

https://gerrit.asterisk.org/c/asterisk/+/18562/comment/9174a8ed_13f0ac84 
PS1, Line 279:  * It is a wrapper around pbx_exec that will execute the application if it exists.
It's not just a wrapper, it also does variable substitution.


https://gerrit.asterisk.org/c/asterisk/+/18562/comment/134e8751_2b1d1196 
PS1, Line 284: int pbx_exec_helper(struct ast_channel *chan, const char *app_name, const char *app_args);
Current functions added should be prefixed with ast_, I also think this could be better named.

ast_pbx_exec_application for example.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18562
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ifee4d2825df7545fb515d763d393065675140c84
Gerrit-Change-Number: 18562
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Tue, 31 May 2022 10:41:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220531/16eb5c53/attachment.html>