[Asterisk-code-review] chan_pjsip: Only set default audio stream on hold. (asterisk[16])

Joshua Colp asteriskteam at digium.com
Tue May 31 05:27:09 CDT 2022


Attention is currently required from: Maximilian Fridrich.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18571 )

Change subject: chan_pjsip: Only set default audio stream on hold.
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

File channels/chan_pjsip.c:

https://gerrit.asterisk.org/c/asterisk/+/18571/comment/043f7f0d_4d1bacaa 
PS3, Line 1470: 	local_hold_set_state(session->active_media_state->default_session[AST_MEDIA_TYPE_AUDIO], held);
There's no need to even have a local_hold_set_state function anymore, it can just go here.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18571
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I04f1110565fd05fea565f5539b534b54549d4f71
Gerrit-Change-Number: 18571
Gerrit-PatchSet: 3
Gerrit-Owner: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Comment-Date: Tue, 31 May 2022 10:27:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220531/1ebf189b/attachment.html>


More information about the asterisk-code-review mailing list