[Asterisk-code-review] chan_pjsip: Only set default audio stream on hold. (asterisk[16])

Maximilian Fridrich asteriskteam at digium.com
Mon May 30 12:48:58 CDT 2022


Attention is currently required from: Joshua Colp.
Maximilian Fridrich has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18571 )

Change subject: chan_pjsip: Only set default audio stream on hold.
......................................................................


Patch Set 3:

(1 comment)

File res/res_pjsip_sdp_rtp.c:

https://gerrit.asterisk.org/c/asterisk/+/18571/comment/143eafbc_27292823 
PS1, Line 2106: 			 * a topoology_change update. Otherwise the hold indication could overwrite the
> And you can access the default audio stream session there using session->active_media_state->default […]
You are right, it was that easy. I tried a similar approach by using ast_channel_get_default_stream() which was a dead end. Thank you.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18571
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I04f1110565fd05fea565f5539b534b54549d4f71
Gerrit-Change-Number: 18571
Gerrit-PatchSet: 3
Gerrit-Owner: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 30 May 2022 17:48:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220530/23ac92ff/attachment.html>


More information about the asterisk-code-review mailing list