[Asterisk-code-review] testsuite: Python 3 compatibility inital commit (testsuite[development/16/python3])

George Joseph asteriskteam at digium.com
Wed May 11 08:11:33 CDT 2022


Attention is currently required from: Michael Bradeen, Joshua Colp.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/testsuite/+/18528 )

Change subject: testsuite: Python 3 compatibility inital commit
......................................................................


Patch Set 3:

(1 comment)

Patchset:

PS3: 
> > I get the same error as Jenkins when running self-test...
> > ImportError: No module named machinery
> > 
> 
> That's running python2.

Just saw the comment on the other review about not needing to support 2.7 so don't worry about this one.

BUT when running python3 I get...

  File "lib/python/asterisk/test_config.py", line 511, in dependency_factory
    TestConfig.dependency_cache[key] = Dependency(dep)
  File "lib/python/asterisk/test_config.py", line 119, in __init__
    __import__(self.name)
  File "/var/lib/asterisk/third-party/pjproject/pjsua.py", line 2959
    print "** ",
              ^
SyntaxError: Missing parentheses in call to 'print'. Did you mean print("** ", end=" ")?

Is there a prereq patch for bundled asterisk that fixes that?



-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/18528
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: development/16/python3
Gerrit-Change-Id: I55caad3cb2a156b8e3f2f24dd10db5ebe67910d2
Gerrit-Change-Number: 18528
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 11 May 2022 13:11:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220511/26a48076/attachment-0001.html>


More information about the asterisk-code-review mailing list