<p> Attention is currently required from: Michael Bradeen, Joshua Colp. </p>
<p><a href="https://gerrit.asterisk.org/c/testsuite/+/18528">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Patchset:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/18528?tab=comments">Patch Set #3:</a> </p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">I get the same error as Jenkins when running self-test...<br>ImportError: No module named machinery<br></p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">That's running python2.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Just saw the comment on the other review about not needing to support 2.7 so don't worry about this one.</p><p style="white-space: pre-wrap; word-wrap: break-word;">BUT when running python3 I get...</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  File "lib/python/asterisk/test_config.py", line 511, in dependency_factory<br>    TestConfig.dependency_cache[key] = Dependency(dep)<br>  File "lib/python/asterisk/test_config.py", line 119, in __init__<br>    __import__(self.name)<br>  File "/var/lib/asterisk/third-party/pjproject/pjsua.py", line 2959<br>    print "** ",<br>              ^<br>SyntaxError: Missing parentheses in call to 'print'. Did you mean print("** ", end=" ")?</pre><p style="white-space: pre-wrap; word-wrap: break-word;">Is there a prereq patch for bundled asterisk that fixes that?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/testsuite/+/18528">change 18528</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/testsuite/+/18528"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: development/16/python3 </div>
<div style="display:none"> Gerrit-Change-Id: I55caad3cb2a156b8e3f2f24dd10db5ebe67910d2 </div>
<div style="display:none"> Gerrit-Change-Number: 18528 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-CC: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-CC: Mark Petersen <bugs.digium.com@zombie.dk> </div>
<div style="display:none"> Gerrit-Attention: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 11 May 2022 13:11:33 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>