[Asterisk-code-review] crypto: Don't load non-regular files in keys directory (asterisk[master])

[George Joseph]

Attention is currently required from: Philip Prindeville.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18533 )

Change subject: crypto: Don't load non-regular files in keys directory
......................................................................


Patch Set 5: Code-Review-1

(3 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/18533/comment/6a598c5b_229d8f9e 
PS5, Line 7: crypto
Use the full module name when possible. "res_crypto"


https://gerrit.asterisk.org/c/asterisk/+/18533/comment/f771d8de_e4cc8095 
PS5, Line 11: Signed-off-by: Philip Prindeville <philipp at redfish-solutions.com>
We don't use "signed-off-by".  It should be removed.


File res/res_crypto.c:

https://gerrit.asterisk.org/c/asterisk/+/18533/comment/4b296764_a8f45030 
PS5, Line 519: 				continue;
I'd add a WARNING here that the entry wasn't a regular file.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18533
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie77e0648f8b0b1c2159fb24662d1989cfd4cc36d
Gerrit-Change-Number: 18533
Gerrit-PatchSet: 5
Gerrit-Owner: Philip Prindeville <philipp at redfish-solutions.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Philip Prindeville <philipp at redfish-solutions.com>
Gerrit-Comment-Date: Mon, 09 May 2022 12:05:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220509/b2b9c0ad/attachment.html>