<p> Attention is currently required from: Philip Prindeville. </p>
<p>Patch set 5:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/18533">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18533/comment/6a598c5b_229d8f9e">Patch Set #5, Line 7:</a> <code style="font-family:monospace,monospace">crypto</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Use the full module name when possible. "res_crypto"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18533/comment/f771d8de_e4cc8095">Patch Set #5, Line 11:</a> <code style="font-family:monospace,monospace">Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">We don't use "signed-off-by".  It should be removed.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_crypto.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18533/comment/4b296764_a8f45030">Patch Set #5, Line 519:</a> <code style="font-family:monospace,monospace">                          continue;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I'd add a WARNING here that the entry wasn't a regular file.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/18533">change 18533</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/18533"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie77e0648f8b0b1c2159fb24662d1989cfd4cc36d </div>
<div style="display:none"> Gerrit-Change-Number: 18533 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Philip Prindeville <philipp@redfish-solutions.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Attention: Philip Prindeville <philipp@redfish-solutions.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 09 May 2022 12:05:14 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>