[Asterisk-code-review] app_dial: Fix dial status regression. (asterisk[master])

[N A]

Attention is currently required from: George Joseph.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18521 )

Change subject: app_dial: Fix dial status regression.
......................................................................


Patch Set 2:

(3 comments)

Patchset:

PS2: 
> I'm not sure I understand what's going on here. […]
There were multiple files involved in that issue. The app_dial bit is here: https://gerrit.asterisk.org/c/asterisk/+/13561

The regression is due to forcing CHANUNAVAIL when NULL is returned, which is incorrect.


File apps/app_dial.c:

https://gerrit.asterisk.org/c/asterisk/+/18521/comment/82d833f4_62a21bdc 
PS2, Line 2705: 			ast_log(LOG_NOTICE, "Unable to create channel of type '%s' (cause %d - %s)\n",
> Changing this from WARNING to NOTICE doesn't preserve existing behavior.
It really should be a NOTICE (if not a verbose), not a WARNING. Otherwise, you get a WARNING whenever a busy line is called, which makes literally zero sense.
I can move this into a separate review if desired but throwing a WARNING here is wrong.


https://gerrit.asterisk.org/c/asterisk/+/18521/comment/cf5b14b2_60229203 
PS2, Line 2845: 	if (!valid_peers) {
> Why not just use num_dialed?
Heh, good point. I'll update it to that.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18521
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4d4b209b967816b1bc791534593ababa2b99bb88
Gerrit-Change-Number: 18521
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 09 May 2022 12:02:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220509/7c9d927e/attachment.html>