[Asterisk-code-review] app_dial: Fix dial status regression. (asterisk[master])

[George Joseph]

Attention is currently required from: N A.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18521 )

Change subject: app_dial: Fix dial status regression.
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

Patchset:

PS2: 
I'm not sure I understand what's going on here.  I understand the DADHI bit about returning NULL if there were no channels available but the fix you think caused a regression was in app_chanisavail so I'm a but confused.


File apps/app_dial.c:

https://gerrit.asterisk.org/c/asterisk/+/18521/comment/37dcf9f5_e15c33e5 
PS2, Line 2705: 			ast_log(LOG_NOTICE, "Unable to create channel of type '%s' (cause %d - %s)\n",
Changing this from WARNING to NOTICE doesn't preserve existing behavior.


https://gerrit.asterisk.org/c/asterisk/+/18521/comment/5603302a_d96818c5 
PS2, Line 2845: 	if (!valid_peers) {
Why not just use num_dialed?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18521
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4d4b209b967816b1bc791534593ababa2b99bb88
Gerrit-Change-Number: 18521
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Mon, 09 May 2022 11:41:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220509/0f19d58e/attachment-0001.html>