[Asterisk-code-review] res_pjsip_sdp_rtp: Improve detecting of lack of RTP activity (asterisk[16])

[Joshua Colp]

Attention is currently required from: Boris P. Korzun.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18071 )

Change subject: res_pjsip_sdp_rtp: Improve detecting of lack of RTP activity
......................................................................


Patch Set 1: Code-Review-1

(5 comments)

File res/res_pjsip_sdp_rtp.c:

https://gerrit.asterisk.org/c/asterisk/+/18071/comment/d8f8cfa7_c5265bce 
PS1, Line 124: 	timeout = ast_rtp_instance_get_timeout(rtp);
timeout doesn't need to be retrieved until it is actually used, after the AST_STATE_UP and direct media check


https://gerrit.asterisk.org/c/asterisk/+/18071/comment/2ced450f_1c724499 
PS1, Line 126: 	/* If the channel is not in UP state return for later check. */
Multi-line comments use:

/* Hello
 * World
 */


https://gerrit.asterisk.org/c/asterisk/+/18071/comment/5186a8c3_f7eda160 
PS1, Line 129: 		ast_rtp_instance_set_last_rx(rtp, now);
Add a comment of why this is being done


https://gerrit.asterisk.org/c/asterisk/+/18071/comment/dc41e76c_fcc04ab1 
PS1, Line 131: 		return timeout * 500; /* recheck after half timeout */
Why a half timeout?


https://gerrit.asterisk.org/c/asterisk/+/18071/comment/edbe96ff_bb25b76e 
PS1, Line 2145: 		session_media->timeout_sched_id = ast_sched_add_variable(sched,	500, rtp_check_timeout,
Why the change here?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18071
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I07326d5b9c40f25db717fd6075f6f3a8d77279eb
Gerrit-Change-Number: 18071
Gerrit-PatchSet: 1
Gerrit-Owner: Boris P. Korzun <drtr0jan at yandex.ru>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Boris P. Korzun <drtr0jan at yandex.ru>
Gerrit-Comment-Date: Tue, 01 Mar 2022 13:57:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220301/8f51e079/attachment-0001.html>