<p> Attention is currently required from: Boris P. Korzun. </p>
<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/18071">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_pjsip_sdp_rtp.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18071/comment/d8f8cfa7_c5265bce">Patch Set #1, Line 124:</a> <code style="font-family:monospace,monospace"> timeout = ast_rtp_instance_get_timeout(rtp);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">timeout doesn't need to be retrieved until it is actually used, after the AST_STATE_UP and direct media check</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18071/comment/2ced450f_1c724499">Patch Set #1, Line 126:</a> <code style="font-family:monospace,monospace"> /* If the channel is not in UP state return for later check. */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Multi-line comments use:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">/* Hello<br> * World<br> */</pre></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18071/comment/5186a8c3_f7eda160">Patch Set #1, Line 129:</a> <code style="font-family:monospace,monospace"> ast_rtp_instance_set_last_rx(rtp, now);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Add a comment of why this is being done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18071/comment/dc41e76c_fcc04ab1">Patch Set #1, Line 131:</a> <code style="font-family:monospace,monospace"> return timeout * 500; /* recheck after half timeout */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why a half timeout?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18071/comment/edbe96ff_bb25b76e">Patch Set #1, Line 2145:</a> <code style="font-family:monospace,monospace"> session_media->timeout_sched_id = ast_sched_add_variable(sched, 500, rtp_check_timeout,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why the change here?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/18071">change 18071</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/18071"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I07326d5b9c40f25db717fd6075f6f3a8d77279eb </div>
<div style="display:none"> Gerrit-Change-Number: 18071 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Boris P. Korzun <drtr0jan@yandex.ru> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: Boris P. Korzun <drtr0jan@yandex.ru> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 01 Mar 2022 13:57:48 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>