[Asterisk-code-review] Add support for Python 3 (starpy[1.1])

[Michael Bradeen]

Attention is currently required from: Joshua Colp, Kevin Harwell.
Michael Bradeen has posted comments on this change. ( https://gerrit.asterisk.org/c/starpy/+/18244 )

Change subject: Add support for Python 3
......................................................................


Patch Set 5:

(5 comments)

Commit Message:

https://gerrit.asterisk.org/c/starpy/+/18244/comment/9bbc1fd6_db7f6229 
PS2, Line 7: Changes required for Python 3 compatibility
> Better phrased as "Add support for Python 3"
Done


https://gerrit.asterisk.org/c/starpy/+/18244/comment/5c903138_27364d5a 
PS2, Line 9: manager: Replace 'async' reference with 'nowait'.  This change breaks
           : backwards compatibility with previous versions of the testsuite,
           : requiring a matching change there.
> Is there a way to make this change only for 3+ installs? Otherwise we're forcing ppl to upgrade even […]
Moving to version 1.1 for python 3


File starpy/fastagi.py:

https://gerrit.asterisk.org/c/starpy/+/18244/comment/91851663_ad9e69ab 
PS3, Line 120:         linestring = line.decode("utf-8")
> since all "line" change to "linestring" just make this line = line. […]
Done


File starpy/manager.py:

https://gerrit.asterisk.org/c/starpy/+/18244/comment/2c5ac5a6_04701a84 
PS2, Line 734:         nowait -- make the origination asynchronous
> I'm somewhat ambivalent. If someone else feels strongly that's fine too.
Ack


File starpy/manager.py:

https://gerrit.asterisk.org/c/starpy/+/18244/comment/741653f7_7e8e4446 
PS3, Line 171:         linestring = line.decode("utf-8")
> Same here just make line = line. […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/starpy/+/18244
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: starpy
Gerrit-Branch: 1.1
Gerrit-Change-Id: I2fab42abb5318a5db2af3bcd291fc2db95b87e15
Gerrit-Change-Number: 18244
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 14 Jun 2022 22:04:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Bradeen <mbradeen at sangoma.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220614/9a71c891/attachment.html>