<p> Attention is currently required from: Joshua Colp, Kevin Harwell. </p>
<p><a href="https://gerrit.asterisk.org/c/starpy/+/18244">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/starpy/+/18244/comment/9bbc1fd6_db7f6229">Patch Set #2, Line 7:</a> <code style="font-family:monospace,monospace">Changes required for Python 3 compatibility</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Better phrased as "Add support for Python 3"</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/starpy/+/18244/comment/5c903138_27364d5a">Patch Set #2, Line 9:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">manager: Replace 'async' reference with 'nowait'. This change breaks<br>backwards compatibility with previous versions of the testsuite,<br>requiring a matching change there.<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Is there a way to make this change only for 3+ installs? Otherwise we're forcing ppl to upgrade even […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Moving to version 1.1 for python 3</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File starpy/fastagi.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/starpy/+/18244/comment/91851663_ad9e69ab">Patch Set #3, Line 120:</a> <code style="font-family:monospace,monospace"> linestring = line.decode("utf-8")</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">since all "line" change to "linestring" just make this line = line. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File starpy/manager.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/starpy/+/18244/comment/2c5ac5a6_04701a84">Patch Set #2, Line 734:</a> <code style="font-family:monospace,monospace"> nowait -- make the origination asynchronous</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I'm somewhat ambivalent. If someone else feels strongly that's fine too.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ack</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File starpy/manager.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/starpy/+/18244/comment/741653f7_7e8e4446">Patch Set #3, Line 171:</a> <code style="font-family:monospace,monospace"> linestring = line.decode("utf-8")</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Same here just make line = line. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/starpy/+/18244">change 18244</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/starpy/+/18244"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: starpy </div>
<div style="display:none"> Gerrit-Branch: 1.1 </div>
<div style="display:none"> Gerrit-Change-Id: I2fab42abb5318a5db2af3bcd291fc2db95b87e15 </div>
<div style="display:none"> Gerrit-Change-Number: 18244 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Attention: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 14 Jun 2022 22:04:54 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Comment-In-Reply-To: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Comment-In-Reply-To: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>